Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use line_item price instead of variant price in return_authorization #2342

Closed
wants to merge 1 commit into from
Closed

Use line_item price instead of variant price in return_authorization #2342

wants to merge 1 commit into from

Conversation

sanemat
Copy link
Contributor

@sanemat sanemat commented Dec 19, 2012

The case of return authorization, not variant.price but line_items.first.price to use.

@radar
Copy link
Contributor

radar commented Dec 20, 2012

I don't understand why this pull request is necessary. In what case would you want to be returning an entire line item rather than just one item contained within that line item?

@radar radar closed this Dec 20, 2012
@sanemat
Copy link
Contributor Author

sanemat commented Dec 21, 2012

In admin/orders/_form, admin/shared/_order_details, admin/orders/_add_product use line_items(price at the time), but admin/return_authorizations/_form uses current variant price, I want to use price at the time in return authorization case.
inventory unit does not have price at the time, line item has price at the time.

@radar radar reopened this Dec 21, 2012
@radar
Copy link
Contributor

radar commented Dec 21, 2012

Ok, I see your point now. Thanks for explaining it.

@radar radar closed this in 587599d Jan 2, 2013
radar pushed a commit that referenced this pull request Jan 2, 2013
@sanemat @radar
Use line_item price instead of variant price
1b95633 
Fixes #2342
@sanemat sanemat deleted the return-authorization branch November 1, 2013 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sanemat @radar